Skip to content

QUIC: Add memory_reduction_timeout configuration#44408

Merged
RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom
fishpan1209:gfe-idle
Apr 15, 2026
Merged

QUIC: Add memory_reduction_timeout configuration#44408
RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom
fishpan1209:gfe-idle

Conversation

@fishpan1209
Copy link
Copy Markdown
Contributor

@fishpan1209 fishpan1209 commented Apr 13, 2026

Commit Message: quic: add memory_reduction_timeout configuration support
Additional Description: Added a new configuration option memory_reduction_timeout to QuicProtocolOptions to allow setting a timeout for memory reduction callbacks when the network is idle.
Risk Level: low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@fishpan1209
quic: add memory_reduction_timeout configuration
2ba45d0 
Signed-off-by: Ting Pan <panting@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Apr 13, 2026

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44408 was opened by fishpan1209.

see: more, trace.

@fishpan1209
reformat
0a1d9be 
Signed-off-by: Ting Pan <panting@google.com>
@fishpan1209
Copy link
Copy Markdown
Contributor Author

fishpan1209 commented Apr 13, 2026

/retest

1 similar comment
@fishpan1209
Copy link
Copy Markdown
Contributor Author

fishpan1209 commented Apr 13, 2026

/retest

@fishpan1209 fishpan1209 changed the title quic: add memory_reduction_timeout configuration QUIC: Add memory_reduction_timeout configuration support Apr 13, 2026
@fishpan1209 fishpan1209 changed the title QUIC: Add memory_reduction_timeout configuration support QUIC: Add memory_reduction_timeout configuration Apr 13, 2026
@fishpan1209
Copy link
Copy Markdown
Contributor Author

fishpan1209 commented Apr 13, 2026

/assign @wang178c

@fishpan1209
Copy link
Copy Markdown
Contributor Author

fishpan1209 commented Apr 13, 2026

/retest

@fishpan1209 fishpan1209 marked this pull request as ready for review April 13, 2026 20:14
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Apr 13, 2026

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #44408 was ready_for_review by fishpan1209.

see: more, trace.

wang178c
wang178c approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wang178c wang178c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

adisuissa
adisuissa reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

Please add tests that validate that this is working as expected.

cc @RyanTheOptimist :
are these kind of features supported by the general QUIC implementations, or are they specific to the QUICHE implementation that Envoy uses?

@wang178c
Copy link
Copy Markdown
Contributor

wang178c commented Apr 14, 2026

Thanks!

Please add tests that validate that this is working as expected.

This feature has been tested internally and is a straightforward QUICHE knob. We have test coverage in QUICHE.

cc @RyanTheOptimist : are these kind of features supported by the general QUIC implementations, or are they specific to the QUICHE implementation that Envoy uses?

This feature is generally useful for any non-frontline proxy and has been validated in two other non-Envoy-based proxies internally.

@fishpan1209
add unit test
f1c4a0b 
Signed-off-by: Ting Pan <panting@google.com>
@fishpan1209
Copy link
Copy Markdown
Contributor Author

fishpan1209 commented Apr 15, 2026

/assign @RyanTheOptimist

@fishpan1209
Copy link
Copy Markdown
Contributor Author

fishpan1209 commented Apr 15, 2026

/retest

@adisuissa
Copy link
Copy Markdown
Contributor

adisuissa commented Apr 15, 2026

Thanks!

Please add tests that validate that this is working as expected.

This feature has been tested internally and is a straightforward QUICHE knob. We have test coverage in QUICHE.

cc @RyanTheOptimist : are these kind of features supported by the general QUIC implementations, or are they specific to the QUICHE implementation that Envoy uses?

This feature is generally useful for any non-frontline proxy and has been validated in two other non-Envoy-based proxies internally.

It is generally preferable to have all the QUICHE related knobs in a QUICHE specific type, regardless of frontline/non-frontline proxy. That is features that should be configured for any QUIC implementation will be added to QuicProtocolOptions, and implementation specific features will be added to the implementation-specific type.

adisuissa
adisuissa reviewed Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@RyanTheOptimist RyanTheOptimist merged commit a99a8b0 into envoyproxy:main Apr 15, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisuissa adisuissa adisuissa left review comments

@RyanTheOptimist RyanTheOptimist RyanTheOptimist approved these changes

+1 more reviewer

@wang178c wang178c wang178c approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adisuissa adisuissa

@RyanTheOptimist RyanTheOptimist

@wang178c wang178c

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fishpan1209 @wang178c @adisuissa @RyanTheOptimist